Skip to content

Conversation

@ryan-lempka
Copy link
Collaborator

@ryan-lempka ryan-lempka commented Nov 10, 2025

Changes

  • Fixed inaccurate descriptions (config cell, NIM comment, SciDocs explanation)
  • Removed duplicate import statement
  • Added Next Steps section with achievement summary (baseline 0.159 → 0.176 recall@5), links to README and docs
  • Removed verbose old conclusion
  • Cleared notebook outputs

"execution_count": null,
"id": "3ac11757",
"metadata": {},
"outputs": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: how did these logs get removed ?

Copy link
Collaborator Author

@ryan-lempka ryan-lempka Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabhatinas cleared output on the notebook via "Clear All Outputs". Per the RFC currently under review I think we should propose this as a new standard - I don't think the outputs should be uploaded for the following reasons:

1/ Diffs become messy due to variation in output and cell counts from different contributors
2/ They lengthen the notebooks unnecessarily
3/ It's unclear when running a notebook if your cell produced output or if the output was there prior

Aside from these reasons the other example notebooks I have seen elsewhere do the same.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! As long as this is a conscious choice and we make it the standard, it should be okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants